chore: Add X-Goog-Api-Client metric header to outgoing requests
#655
+58
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanedey
commented
Nov 19, 2024
appcheck/appcheck.go
Outdated
| @@ -77,6 +78,7 @@ func NewClient(ctx context.Context, conf *internal.AppCheckConfig) (*Client, err | |||
| jwks, err := keyfunc.Get(JWKSUrl, keyfunc.Options{ | |||
| Ctx: ctx, | |||
| RefreshInterval: 6 * time.Hour, | |||
| RequestFactory: makeRequestFactory(conf), | |||
There was a problem hiding this comment.
Only way to pass headers here is to pass it through a request factory. This is a little more involved, should I separate this change into it's own PR?
There was a problem hiding this comment.
Since this request is just for the key server (we might not track the requests there anyways) let's skip it for now then.
lahirumaramba
approved these changes
Nov 20, 2024
| @@ -441,3 +443,9 @@ func retryNetworkAndHTTPErrors(statusCodes ...int) RetryCondition { | |||
| return false | |||
| } | |||
| } | |||
|
|
|||
| // GetMetricsHeader constructs header value for metrics attribution | |||
| func GetMetricsHeader(sdkVersion string) string { | |||
There was a problem hiding this comment.
Is it possible to access the Version in here? That might be better than passing it in from all the APIs separately.
There was a problem hiding this comment.
Not possible, that would cause a dependency cycle. I'm not a fan of how this is structured either. I would prefer if we kept the Version value separately from firebase.go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
This does not include: